zhfeng commented on code in PR #14130:
URL: https://github.com/apache/shardingsphere/pull/14130#discussion_r907986635
##########
shardingsphere-kernel/shardingsphere-transaction/shardingsphere-transaction-core/src/main/java/org/apache/shardingsphere/transaction/core/TransactionType.java:
##########
@@ -22,7 +22,7 @@
*/
public enum TransactionType {
- LOCAL, XA, BASE;
+ LOCAL, XA, BASE, MANUALXA;
Review Comment:
`MANUALXA` is not a good name. It might be better to use `NONE` or
`TRANSPARENT`. you know, naming is a hard work!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
