terrymanu commented on code in PR #19047:
URL: https://github.com/apache/shardingsphere/pull/19047#discussion_r920312082
##########
shardingsphere-infra/shardingsphere-infra-common/src/main/java/org/apache/shardingsphere/infra/database/type/DatabaseTypeFactory.java:
##########
@@ -29,7 +29,7 @@
*/
@NoArgsConstructor(access = AccessLevel.PRIVATE)
public final class DatabaseTypeFactory {
-
+
Review Comment:
Please do not change the original indent
##########
shardingsphere-infra/shardingsphere-infra-common/src/test/java/org/apache/shardingsphere/infra/database/type/DatabaseTypeFactoryTest.java:
##########
@@ -57,4 +57,17 @@ public void assertGetInstances() {
assertThat(iterator.next(), instanceOf(SQLServerDatabaseType.class));
assertThat(iterator.next(), instanceOf(H2DatabaseType.class));
}
+
+ @Test
+ public void assertGetDatabaseType() {
Review Comment:
Please rename the method to `assertGetInstance` if the target test method is
`getInstance`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
