sandynz commented on code in PR #19406:
URL: https://github.com/apache/shardingsphere/pull/19406#discussion_r926336480
##########
shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-scaling/src/test/java/org/apache/shardingsphere/integration/data/pipeline/framework/container/compose/DockerComposedContainer.java:
##########
@@ -38,15 +38,20 @@ public final class DockerComposedContainer extends
BaseComposedContainer {
private final ShardingSphereProxyDockerContainer proxyContainer;
+ private final ShardingSphereProxyDockerContainer anotherProxyContainer;
+
private final DatabaseContainer databaseContainer;
public DockerComposedContainer(final DatabaseType databaseType, final
String dockerImageName) {
this.databaseType = databaseType;
- ShardingSphereProxyDockerContainer proxyContainer = new
ShardingSphereProxyDockerContainer(databaseType);
governanceContainer = getContainers().registerContainer(new
ZookeeperContainer());
databaseContainer =
getContainers().registerContainer(DatabaseContainerFactory.newInstance(databaseType,
dockerImageName));
+ ShardingSphereProxyDockerContainer proxyContainer = new
ShardingSphereProxyDockerContainer(databaseType);
proxyContainer.dependsOn(governanceContainer, databaseContainer);
+ ShardingSphereProxyDockerContainer anotherProxyContainer = new
ShardingSphereProxyDockerContainer(databaseType);
+ anotherProxyContainer.dependsOn(governanceContainer,
databaseContainer);
this.proxyContainer =
getContainers().registerContainer(proxyContainer);
+ this.anotherProxyContainer =
getContainers().registerContainer(anotherProxyContainer);
Review Comment:
`this.` could be removed
##########
shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-scaling/src/test/java/org/apache/shardingsphere/integration/data/pipeline/framework/container/compose/DockerComposedContainer.java:
##########
@@ -38,15 +38,20 @@ public final class DockerComposedContainer extends
BaseComposedContainer {
private final ShardingSphereProxyDockerContainer proxyContainer;
+ private final ShardingSphereProxyDockerContainer anotherProxyContainer;
+
Review Comment:
1, Seems could be local variable in constructor
2, Should `anotherProxyContainer` be closed on stop()?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
