terrymanu opened a new issue, #19655: URL: https://github.com/apache/shardingsphere/issues/19655
There are lots of different between SQL dialects, such as `create table`. We need do more design of JDBCRepository and H2Repository. 1. It is better to refactor JDBCRepository as final class, and use JDBCRepositoryProvider as interface. 2. H2JDBCRepositoryProvider and other database dialect can implements JDBCRepositoryProvider and import as SPI. 3. There are lots of method need to be designed in JDBCRepositoryProvider, such `createTableSQL` and `dropTableSQL` etc. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
