linghengqian commented on PR #19806: URL: https://github.com/apache/shardingsphere/pull/19806#issuecomment-1204003271
@terrymanu - I think it's a good idea to restrict `H2SchemaMetaDataLoader` to only execute SQL checking metadata in `H2Databse 1.x`, which emphasizes that this class is only responsible for `H2Database 1.x`, and solves the original issue. Because `when the dialect load has error, then we'll use default load`. Refer to https://github.com/apache/shardingsphere/issues/15327#issuecomment-1034445953. - The change to `JDBCRepository` is actually because `H2Database 2.x` has added a large number of keywords to be consistent with `MySQL` and `PostgreSQL`. I think adding backticks to SQL key fields is the easiest solution to be compatible with `H2Database 2.x`. - If we choose to update `H2Database 2.x` for the project, I think it is necessary for us to consider dropping support for `H2Database 1.x`, because unit tests do not reflect this compatibility at all. - This should be a discussion issue as `H2Database 1.x` is no longer maintained. From the point of view of users' downstream projects, it is impossible for them to use two different versions of H2Database, such as SpringBoot 2.7.x, JOOQ 3.5.x, r2dbc-h2 1.0.0 driver and other popular applications only use H2Database 2.x, Compatibility with H2Database 1.x is not considered. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@shardingsphere.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
