sandynz opened a new issue, #19936: URL: https://github.com/apache/shardingsphere/issues/19936
Currently, AbstractImporter.getSchemaName is an abstract method, and it's implemented in MySQLImporter / PostgreSQLImporter / OpenGaussImporter. In fact, it could be implemented in AbstractImporter, to simplify AbstractImporter sub-classes, and ImporterFactory / ScalingEntry later. Possible changes: - Refactor ImporterConfiguration.getSchemaName, check schema available or not by `DatabaseTypeFactory.getInstance(databaseType).isSchemaAvailable();`, return null if schema is not available - Remove `abstract` on AbstractImporter.getSchemaName; Change `protected` to `private` - Remove implementations of AbstractImporter.getSchemaName Following classes and methods could be referenced, they could be used to implement getSchemaName in AbstractImporter: - AbstractImporter.getImporterConfig() - ImporterConfiguration.getDataSourceConfig() - PipelineDataSourceConfiguration.getDatabaseType() - DatabaseType.isSchemaAvailable() -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
