sandynz commented on PR #19949: URL: https://github.com/apache/shardingsphere/pull/19949#issuecomment-1207946077
@huangdx0726 , OK, since DefaultImporter is created now but not FixtureImporter. It need incrementalTask stop, but it might need to change much unit test classes. In order to make it compatible with current unit tests, and we need to remove ScalingEntry finally, we could take another way. Possible changes: - Add ImporterCreator interface, it extends TypedSPI, marked as `@SingletonSPI` - ImporterCreator has 2 sub-classes, FixtureImporterCreator and DefaultImporterCreator; FixtureImporterCreator's type is H2, DefaultImporterCreator's type is MySQL and typeAliases are PostgreSQL & openGauss - Refactor ImporterFactory to ImporterCreatorFactory Examples: - PositionInitializer and PositionInitializerFactory, #15180 - PipelineChannelCreator and PipelineChannelCreatorFactory -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
