tydhot commented on a change in pull request #2297:
URL: https://github.com/apache/incubator-shenyu/pull/2297#discussion_r742496786
##########
File path:
shenyu-spring-boot-starter/shenyu-spring-boot-starter-client/shenyu-spring-boot-starter-client-springcloud/src/main/java/org/apache/shenyu/springboot/starter/client/springcloud/ShenyuSpringCloudClientConfiguration.java
##########
@@ -38,16 +38,16 @@
/**
* Spring cloud client bean post processor spring cloud client bean post
processor.
*
- * @param env the env
- * @param shenyuClientRegisterRepository the shenyu client register
repository
* @param clientConfig the client config
+ * @param shenyuClientRegisterRepository the shenyu client register
repository
+ * @param env the env
* @return the spring cloud client bean post processor
*/
@Bean
- public SpringCloudClientBeanPostProcessor
springCloudClientBeanPostProcessor(final Environment env,
+ public SpringCloudClientBeanPostProcessor
springCloudClientBeanPostProcessor(final ShenyuClientConfig clientConfig,
Review comment:
to be honset, i really think the change like this is meaningless
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]