tydhot commented on a change in pull request #2388:
URL: https://github.com/apache/incubator-shenyu/pull/2388#discussion_r751289107
##########
File path:
shenyu-plugin/shenyu-plugin-tars/src/main/java/org/apache/shenyu/plugin/tars/util/PrxInfoUtil.java
##########
@@ -141,9 +141,11 @@ public static String getObjectName(final String
upstreamUrl, final String servic
public static Object[] getParamArray(final Class<?>[] paramTypes, final
String[] paramNames, final String body) {
Map<String, Object> bodyMap =
GsonUtils.getInstance().convertToMap(body);
Object[] param = new Object[paramNames.length];
+ String paramName;
+ Class<?> paramType;
for (int i = 0; i < paramNames.length; i++) {
- String paramName = paramNames[i];
- Class<?> paramType = paramTypes[i];
+ paramName = paramNames[i];
+ paramType = paramTypes[i];
Review comment:
I dont think change like this is a good choise.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
