dragon-zhang commented on a change in pull request #2844:
URL: https://github.com/apache/incubator-shenyu/pull/2844#discussion_r802242769
##########
File path:
shenyu-client/shenyu-client-dubbo/shenyu-client-alibaba-dubbo/src/main/java/org/apache/shenyu/client/alibaba/dubbo/AlibabaDubboServiceBeanListener.java
##########
@@ -100,19 +101,19 @@ private void handler(final ServiceBean<?> serviceBean) {
}
Method[] methods = ReflectionUtils.getUniqueDeclaredMethods(clazz);
for (Method method : methods) {
- ShenyuDubboClient shenyuDubboClient =
method.getAnnotation(ShenyuDubboClient.class);
- if (Objects.nonNull(shenyuDubboClient)) {
- publisher.publishEvent(buildMetaDataDTO(serviceBean,
shenyuDubboClient, method));
+ SoulDubboClient dubboClient =
AnnotatedElementUtils.findMergedAnnotation(method, SoulDubboClient.class);
+ if (Objects.nonNull(dubboClient)) {
+ publisher.publishEvent(buildMetaDataDTO(serviceBean,
dubboClient, method));
}
}
}
- private MetaDataRegisterDTO buildMetaDataDTO(final ServiceBean<?>
serviceBean, final ShenyuDubboClient shenyuDubboClient, final Method method) {
+ private MetaDataRegisterDTO buildMetaDataDTO(final ServiceBean<?>
serviceBean, final SoulDubboClient dubboClient, final Method method) {
Review comment:
`@ShenyuDubboClient` is a derived annotation of `@SoulDubboClient`.
```java
@Retention(RetentionPolicy.RUNTIME)
@Target({ElementType.TYPE, ElementType.METHOD})
@Inherited
@SoulDubboClient(path = "")
public @interface ShenyuDubboClient {
@AliasFor(annotation = SoulDubboClient.class)
String path();
@AliasFor(annotation = SoulDubboClient.class)
String ruleName() default "";
@AliasFor(annotation = SoulDubboClient.class)
String desc() default "";
@AliasFor(annotation = SoulDubboClient.class)
boolean enabled() default true;
}
```
see `org.springframework.core.annotation.AliasFor` and
`org.springframework.core.annotation.AnnotatedElementUtils#findMergedAnnotation`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
