hgaol commented on issue #2927: URL: https://github.com/apache/incubator-shenyu/issues/2927#issuecomment-1048590850
> it set value, i think the logic should be to set defaults if you don't have them and configure them if you do~ If like you mentioned, I think it needs to be updated. BTW, many fields like `limitForPeriod` are `int` or `long`, which means it will always has a number. Considering 0 is also an valid config in `resilience4j` for some scenarios, could I just verify the number and replace with default when it's less than 0. Like, ```java resilience4JHandle.setLimitForPeriod(resilience4JHandle.getLimitForPeriod() < 0 ? Constants.LIMIT_FOR_PERIOD : resilience4JHandle.getLimitForPeriod()); ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
