li-keguo commented on a change in pull request #2936:
URL: https://github.com/apache/incubator-shenyu/pull/2936#discussion_r814457872
##########
File path:
shenyu-disruptor/src/main/java/org/apache/shenyu/disruptor/event/OrderlyDisruptorEventFactory.java
##########
@@ -24,7 +24,7 @@
* disruptor Create a factory implementation of the object.
* @param <T> the type parameter
*/
-public class OrderlyDisruptorEventFactory<T> implements
EventFactory<OrderlyDataEvent<T>> {
+public class OrderlyDisruptorEventFactory<T> implements
EventFactory<DataEvent<T>> {
Review comment:
the method DisruptorProviderManage#startup(boolean) has code:
```
EventFactory<DataEvent<T>> eventFactory;
if (isOrderly) {
newConsumerSize = 1;
// if OrderlyDisruptorEventFactory is OrderlyDataEvent ,it warning
eventFactory = new OrderlyDisruptorEventFactory<>();
} else {
eventFactory = new DisruptorEventFactory<>();
}
```
I've tried to clear up some of the generics issues that have been suppressed
before, but haven't been successful. give me sometime
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
