yu199195 commented on a change in pull request #2946:
URL: https://github.com/apache/incubator-shenyu/pull/2946#discussion_r815763052
##########
File path:
shenyu-admin/src/main/java/org/apache/shenyu/admin/listener/AbstractDataChangedListener.java
##########
@@ -96,25 +95,13 @@
ConfigDataCache config = CACHE.get(groupKey.name());
switch (groupKey) {
case APP_AUTH:
- List<AppAuthData> appAuthList =
GsonUtils.getGson().fromJson(config.getJson(), new
TypeToken<List<AppAuthData>>() {
- }.getType());
- return new ConfigData<>(config.getMd5(),
config.getLastModifyTime(), appAuthList);
case PLUGIN:
- List<PluginData> pluginList =
GsonUtils.getGson().fromJson(config.getJson(), new
TypeToken<List<PluginData>>() {
- }.getType());
- return new ConfigData<>(config.getMd5(),
config.getLastModifyTime(), pluginList);
case RULE:
- List<RuleData> ruleList =
GsonUtils.getGson().fromJson(config.getJson(), new TypeToken<List<RuleData>>() {
- }.getType());
- return new ConfigData<>(config.getMd5(),
config.getLastModifyTime(), ruleList);
case SELECTOR:
- List<SelectorData> selectorList =
GsonUtils.getGson().fromJson(config.getJson(), new
TypeToken<List<SelectorData>>() {
- }.getType());
- return new ConfigData<>(config.getMd5(),
config.getLastModifyTime(), selectorList);
case META_DATA:
- List<MetaData> metaList =
GsonUtils.getGson().fromJson(config.getJson(), new TypeToken<List<MetaData>>() {
+ List<?> appAuthList =
GsonUtils.getGson().fromJson(config.getJson(), new TypeToken<List<?>>() {
Review comment:
why refactor this？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
