dragon-zhang commented on a change in pull request #3029:
URL: https://github.com/apache/incubator-shenyu/pull/3029#discussion_r824513405
##########
File path:
shenyu-plugin/shenyu-plugin-general-context/src/main/java/org/apache/shenyu/plugin/general/context/GeneralContextPlugin.java
##########
@@ -60,8 +60,9 @@
generalContextMapWithRpcType.put(each.getGeneralContextKey(),
each.getGeneralContextValue());
break;
case Constants.TRANSMIT_HEADER_TO_GENERAL_CONTEXT_TYPE:
+ final List<String> header =
headers.get(each.getGeneralContextKey());
Review comment:
> varable
If a parameter can be either mutable or immutable, it's better to make it
immutable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
