midnight2104 commented on a change in pull request #3091:
URL: https://github.com/apache/incubator-shenyu/pull/3091#discussion_r832737439



##########
File path: shenyu-admin/src/main/resources/mappers/auth-param-sqlmap.xml
##########
@@ -28,100 +28,103 @@
     </resultMap>
 
     <sql id="Base_Column_List">
-        id, auth_id, app_name,app_param,date_created, date_updated
+        id,
+        auth_id,
+        app_name,
+        app_param,
+        date_created,
+        date_updated
     </sql>
 
     <select id="findByAuthId" parameterType="java.lang.String" 
resultMap="BaseResultMap">
-        select
-        <include refid="Base_Column_List"/>
-        from auth_param
-        where auth_id = #{authId,jdbcType=VARCHAR}
+        SELECT
+            <include refid="Base_Column_List"/>
+        FROM auth_param
+        WHERE auth_id = #{authId, jdbcType=VARCHAR}
     </select>
 
     <select id="findByAuthIdList" parameterType="java.lang.String" 
resultMap="BaseResultMap">
-        select
-        <include refid="Base_Column_List"/>
-        from auth_param
-        where auth_id in
-        <foreach collection="authIdSet" index="index" item="authId"
-                 open="(" separator="," close=")" >
-            #{authId,jdbcType=VARCHAR}
-        </foreach>
+        SELECT
+            <include refid="Base_Column_List"/>
+        FROM auth_param
+        WHERE auth_id IN
+            <foreach collection="authIdSet" index="index" item="authId"
+                     open="(" separator="," close=")">
+                #{authId, jdbcType=VARCHAR}
+            </foreach>
     </select>
 
-    <select id="findByAuthIdAndAppName"  resultMap="BaseResultMap">
-        select
-        <include refid="Base_Column_List"/>
-        from auth_param
-        where auth_id = #{authId,jdbcType=VARCHAR}
-        and app_name = #{appName,jdbcType=VARCHAR}
-        limit 1
+    <select id="findByAuthIdAndAppName" resultMap="BaseResultMap">
+        SELECT
+            <include refid="Base_Column_List"/>
+        FROM auth_param
+        WHERE auth_id = #{authId, jdbcType=VARCHAR}
+            AND app_name = #{appName, jdbcType=VARCHAR}
+        LIMIT 1
     </select>
 
 
     <insert id="save" 
parameterType="org.apache.shenyu.admin.model.entity.AuthParamDO">
-        insert into auth_param
-        (id,
-        auth_id,
-        app_name,
-        app_param,
-        date_created,
-        date_updated)
-        values
-         (
-         #{id,jdbcType=VARCHAR},
-         #{authId,jdbcType=VARCHAR},
-         #{appName,jdbcType=VARCHAR},
-         #{appParam,jdbcType=VARCHAR},
-         #{dateCreated,jdbcType=TIMESTAMP},
-         #{dateUpdated,jdbcType=TIMESTAMP})
+        INSERT INTO auth_param
+            (id,
+            auth_id,
+            app_name,
+            app_param,
+            date_created,
+            date_updated)
+        VALUES
+            (#{id, jdbcType=VARCHAR},
+            #{authId, jdbcType=VARCHAR},
+            #{appName, jdbcType=VARCHAR},
+            #{appParam, jdbcType=VARCHAR},
+            #{dateCreated, jdbcType=TIMESTAMP},
+            #{dateUpdated, jdbcType=TIMESTAMP})
     </insert>
 
     <insert id="batchSave">
         INSERT INTO auth_param
-        (id,
-        auth_id,
-        app_name,
-        app_param,
-        date_created,
-        date_updated)
+            (id,
+            auth_id,
+            app_name,
+            app_param,
+            date_created,
+            date_updated)
         VALUES

Review comment:
       The keywords are not right-aligned.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to