midnight2104 commented on a change in pull request #3094:
URL: https://github.com/apache/incubator-shenyu/pull/3094#discussion_r832738210
##########
File path: shenyu-admin/src/main/resources/mappers/shenyu-dict-sqlmap.xml
##########
@@ -32,65 +32,89 @@
</resultMap>
<sql id="Base_Column_List">
- id, `type`, dict_code, dict_name, dict_value, `desc`, sort, enabled,
date_created, date_updated
+ id,
+ `type`,
+ dict_code,
+ dict_name,
+ dict_value,
+ `desc`,
+ sort,
+ enabled,
+ date_created,
+ date_updated
</sql>
<select id="selectById" parameterType="java.lang.String"
resultMap="BaseResultMap">
- select
- <include refid="Base_Column_List"/>
- from shenyu_dict
- where id = #{id,jdbcType=VARCHAR}
+ SELECT
Review comment:
The keywords `SELECT` are not right-aligned, it should be set back one
space.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
