[GitHub] [incubator-shenyu] qicz commented on a change in pull request #3096: [type:refactor] optimize webclient message writer to cancel business response override.

Tue, 22 Mar 2022 20:22:00 -0700 


qicz commented on a change in pull request #3096:
URL: https://github.com/apache/incubator-shenyu/pull/3096#discussion_r832810204



##########
File path: 
shenyu-plugin/shenyu-plugin-response/src/main/java/org/apache/shenyu/plugin/response/strategy/WebClientMessageWriter.java
##########
@@ -50,16 +49,10 @@
         return chain.execute(exchange).then(Mono.defer(() -> {
             ServerHttpResponse response = exchange.getResponse();
             ClientResponse clientResponse = 
exchange.getAttribute(Constants.CLIENT_RESPONSE_ATTR);
-            if (Objects.isNull(clientResponse)

Review comment:
       
![image](https://user-images.githubusercontent.com/2174082/159616500-cac0c113-d3f1-4867-8921-090574d88d6b.png)
   this is the current implementation for `WebClientPlugin` that overrides the 
business response status code. and `NettyClientMessageWriter` does not cover 
the business response status code. so I change this code with the same logic.  
I think that the Shenyu process is successful, the business data will be 
transferred completely.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to