dragon-zhang commented on code in PR #3363:
URL: https://github.com/apache/incubator-shenyu/pull/3363#discussion_r861670116
##########
shenyu-plugin/shenyu-plugin-motan/src/main/java/org/apache/shenyu/plugin/motan/cache/ApplicationConfigCache.java:
##########
@@ -185,7 +186,7 @@ public RefererConfig<CommonHandler> build(final MetaData
metaData) {
});
reference.setGroup(motanParamExtInfo.getGroup());
reference.setVersion("1.0");
- reference.setRequestTimeout(1000);
+ reference.setRequestTimeout(motanParamExtInfo.getTimeout());
Review Comment:
If client is not upgraded, `motanParamExtInfo.getTimeout()` will be `null`,
so you should use
`Optional.ofNullable(motanParamExtInfo.getTimeout()).orElse(1000)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
