[incubator-shenyu] branch master updated: [ISSUE #3370] update check style (#3384)

[xiaoyu]

This is an automated email from the ASF dual-hosted git repository.

xiaoyu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-shenyu.git


The following commit(s) were added to refs/heads/master by this push:
     new d7a0c58f8 [ISSUE #3370] update check style (#3384)
d7a0c58f8 is described below

commit d7a0c58f8ce99e825c76670dbfc31a15d454c787
Author: dragon-zhang <hail...@webuy.ai>
AuthorDate: Thu May 5 22:09:30 2022 +0800

    [ISSUE #3370] update check style (#3384)
    
    * [ISSUE #3370] update check style
    
    * remove @author
---
 script/shenyu_checkstyle.xml                       | 23 ++++++++++++++++++----
 .../admin/config/properties/EtcdProperties.java    |  2 --
 2 files changed, 19 insertions(+), 6 deletions(-)

diff --git a/script/shenyu_checkstyle.xml b/script/shenyu_checkstyle.xml
index a7ba4c6e8..d9c91589c 100644
--- a/script/shenyu_checkstyle.xml
+++ b/script/shenyu_checkstyle.xml
@@ -39,6 +39,10 @@
         <property name="format" value="System\.out\.println"/>
         <property name="message" value="Prohibit invoking System.out.println 
in source code !"/>
     </module>
+    <module name="RegexpSingleline">
+        <property name="format" value="@author"/>
+        <property name="message" value="Please remove @author tag in 
javadoc!"/>
+    </module>
 
     <module name="TreeWalker">
 
@@ -49,9 +53,15 @@
         <module name="TypeName"/>
         <module name="MethodName"/>
         <module name="InterfaceTypeParameterName"/>
-        <module name="ClassTypeParameterName"/>
-        <module name="MethodTypeParameterName"/>
-        <module name="ConstantName"/>
+        <module name="ClassTypeParameterName">
+            <property name="format" value="^[A-Z0-9]*$"/>
+        </module>
+        <module name="MethodTypeParameterName">
+            <property name="format" value="^[A-Z0-9]*$"/>
+        </module>
+        <module name="ConstantName">
+            <property name="format" 
value="(^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$)|(^log$)"/>
+        </module>
         <module name="StaticVariableName"/>
         <module name="MemberName"/>
         <module name="LocalVariableName"/>
@@ -64,7 +74,10 @@
 
         <!-- Size Violations -->
         <module name="AnonInnerLength"/>
-        <module name="MethodLength"/>
+        <module name="MethodLength">
+            <property name="tokens" value="METHOD_DEF" />
+            <property name="max" value="80" />
+        </module>
         <module name="LineLength">
             <property name="max" value="200"/>
             <property name="ignorePattern" value="^package.*|^import.*|a 
href|href|http://|https://|ftp://"/>
@@ -184,6 +197,8 @@
         <module name="StringLiteralEquality"/>
         <module name="UnnecessaryParentheses"/>
         <module name="VariableDeclarationUsageDistance"/>
+        <!--Checks that classes that override equals() also override 
hashCode()-->
+        <module name="EqualsHashCode"/>
 
         <!-- Block Checks -->
         <module name="EmptyBlock"/>
diff --git 
a/shenyu-admin/src/main/java/org/apache/shenyu/admin/config/properties/EtcdProperties.java
 
b/shenyu-admin/src/main/java/org/apache/shenyu/admin/config/properties/EtcdProperties.java
index 0727b549e..75fe33fb0 100644
--- 
a/shenyu-admin/src/main/java/org/apache/shenyu/admin/config/properties/EtcdProperties.java
+++ 
b/shenyu-admin/src/main/java/org/apache/shenyu/admin/config/properties/EtcdProperties.java
@@ -21,8 +21,6 @@ import 
org.springframework.boot.context.properties.ConfigurationProperties;
 
 /**
  * etcd config.
- *
- * @author liuwei
  */
 @ConfigurationProperties(prefix = "shenyu.sync.etcd")
 public class EtcdProperties {