dragon-zhang commented on code in PR #3418:
URL: https://github.com/apache/incubator-shenyu/pull/3418#discussion_r881750323
##########
shenyu-plugin/shenyu-plugin-base/src/main/java/org/apache/shenyu/plugin/base/AbstractShenyuPlugin.java:
##########
@@ -42,6 +46,12 @@ public abstract class AbstractShenyuPlugin implements
ShenyuPlugin {
private static final Logger LOG =
LoggerFactory.getLogger(AbstractShenyuPlugin.class);
+ private static ShenyuConfig.MatchCache matchCacheConfig;
+
+ private static SelectorData nullSelectorData = new SelectorData();
+
+ private static RuleData nullRuleData = new RuleData();
Review Comment:
Oh, `nullSelectorData` and `nullRuleData`, maybe shouldn not use `static`
modifer?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
