moremind commented on code in PR #3438:
URL: https://github.com/apache/incubator-shenyu/pull/3438#discussion_r884791976
##########
shenyu-spring-boot-starter/shenyu-spring-boot-starter-plugin/shenyu-spring-boot-starter-plugin-springcloud/src/main/java/org/apache/shenyu/springboot/starter/plugin/springcloud/SpringCloudPluginConfiguration.java:
##########
@@ -48,6 +52,19 @@
@ConditionalOnProperty(value = {"shenyu.plugins.spring-cloud.enabled"},
havingValue = "true", matchIfMissing = true)
public class SpringCloudPluginConfiguration {
+
+ /**
+ * custom blocking loadbalancer.
+ * @param loadBalancerClientFactory loadBalancerFactory
+ * @return loadBalancerClient
+ */
+ @ConditionalOnProperty(value =
{"spring.cloud.loadbalancer.ribbon.enabled"}, havingValue = "false",
matchIfMissing = true)
Review Comment:
use spring cloud loadbalancer
##########
shenyu-plugin/shenyu-plugin-httpclient/src/main/java/org/apache/shenyu/plugin/httpclient/config/HttpClientProperties.java:
##########
@@ -789,9 +789,9 @@ public class Ssl {
private String keyPassword;
/**
- * The default ssl configuration type. Defaults to TCP.
+ * The default ssl configuration type. Defaults to JDK Provider.
*/
- private SslProvider.DefaultConfigurationType defaultConfigurationType
= SslProvider.DefaultConfigurationType.TCP;
+ private SslProvider defaultConfigurationType = SslProvider.JDK;
Review Comment:
I can't sure JDK sslProvider or Open_SSL?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
