hgaol opened a new pull request, #3470:
URL: https://github.com/apache/incubator-shenyu/pull/3470

   // Describe your PR here; eg. Fixes #issueNo
   
   For #3461 , the root cause is because the curator version used in sofa (ver 
4.0.1) is not compatible with 5.2.1. There're several options,
   1. Downgrade curator version in `bootstrap`. It will succeed to run sofa 
applications, but will failed to sync data based on `zookeeper` for 
`bootstrap`. I can create another PR to find any walk around to fix it in 
`bootstrap`.
   2. The other option is tell customers in official documents about this, and 
let them add ver 4.0.1 curator dependencies by themselves. And let them know 
the pros and cons.
   
   This PR is follow option 1, it added curator ver 4.0.1 into `bootstrap` pom 
file, and I'll create another PR to fix the data sync issue in `bootstrap` when 
using 4.0.1.
   
   There're also some other changes, since the `sofa-example` are out-of-date 
and are using curator 2.9.1, which even can't not start up. So I upgraded to 
sofa version 3.12.1, which is released by Apr. 2022.
   
   Make sure that:
   
   - [ ] You have read the [contribution 
guidelines](https://shenyu.apache.org/community/contributor-guide).
   - [ ] You submit test cases (unit or integration tests) that back your 
changes.
   - [ ] Your local test passed `mvn clean install -Dmaven.javadoc.skip=true`.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to