dragon-zhang commented on code in PR #3503:
URL: https://github.com/apache/incubator-shenyu/pull/3503#discussion_r894552821
##########
shenyu-client/shenyu-client-tars/src/main/java/org/apache/shenyu/client/tars/TarsServiceBeanPostProcessor.java:
##########
@@ -96,18 +96,8 @@ private void handler(final Object serviceBean) {
if (AopUtils.isAopProxy(serviceBean)) {
clazz = AopUtils.getTargetClass(serviceBean);
}
+ String serviceName =
clazz.getAnnotation(ShenyuTarsService.class).serviceName();
Method[] methods = ReflectionUtils.getUniqueDeclaredMethods(clazz);
- ShenyuTarsService shenyuTarsService =
clazz.getAnnotation(ShenyuTarsService.class);
- String serviceName = shenyuTarsService.serviceName();
- if (serviceName.contains("*")) {
- for (Method method : methods) {
- ShenyuTarsClient shenyuTarsClient =
method.getAnnotation(ShenyuTarsClient.class);
- if (Objects.nonNull(shenyuTarsClient)) {
- publisher.publishEvent(buildMetaDataDTO(serviceName,
shenyuTarsClient, method, buildRpcExtJson(method)));
Review Comment:
Just need to simplify code, not remove these code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
