sunshujie1990 commented on issue #3521:
URL:
https://github.com/apache/incubator-shenyu/issues/3521#issuecomment-1153873068
@dragon-zhang Hi dragon. While adding the `shenyu.sharedPool.enable`
property, my ide (IntelliJ IDEA) autocomplete the property key to
`shenyu.shared-pool.enable` which results shared thread pool not effective. I
think this is because of the implemention does not follow spring-boot's
specification.
Shenyu implemention:
```
@Bean
@ConditionalOnProperty(name = "shenyu.sharedPool.enable", havingValue =
"true")
```
spring-boot doc:
```
/**
* The name of the properties to test. If a prefix has been defined, it
is applied to
* compute the full key of each property. For instance if the prefix is
* {@code app.config} and one value is {@code my-value}, the full key
would be
* {@code app.config.my-value}
* <p>
* Use the dashed notation to specify each property, that is all lower
case with a "-"
* to separate words (e.g. {@code my-long-property}).
* @return the names
*/
String[] name() default {};
```
https://github.com/spring-projects/spring-boot/blob/2.6.x/spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/condition/ConditionalOnProperty.java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
