skyleaworlder opened a new pull request, #3652: URL: https://github.com/apache/incubator-shenyu/pull/3652
<!-- Describe your PR here; eg. Fixes #issueNo --> About #3513 <!-- Thank you for proposing a pull request. This template will guide you through the essential steps necessary for a pull request. --> Make sure that: - [x] You have read the [contribution guidelines](https://shenyu.apache.org/community/contributor-guide). - [x] You submit test cases (unit or integration tests) that back your changes. - [ ] Your local test passed `./mvnw clean install -Dmaven.javadoc.skip=true`. ### Change packaging plugin Former packaging plugin is [dockerfile-maven-plugin](https://github.com/spotify/dockerfile-maven), which is archived now. The new packaging plugin is [docker-maven-plugin](https://github.com/fabric8io/docker-maven-plugin). [dockerfile-maven-plugin](https://github.com/spotify/dockerfile-maven) used as: ```xml <plugin> <groupId>com.spotify</groupId> <artifactId>dockerfile-maven-plugin</artifactId> <version>${dockerfile-maven-plugin.version}</version> <executions> <execution> <id>shenyu-integrated-test-apache-dubbo</id> <goals> <goal>build</goal> </goals> </execution> </executions> <configuration> <repository>shenyu-integrated-test-apache-dubbo</repository> <tag>latest</tag> <buildArgs> <APP_NAME>shenyu-integrated-test-apache-dubbo</APP_NAME> </buildArgs> </configuration> </plugin> ``` [docker-maven-plugin](https://github.com/fabric8io/docker-maven-plugin) can be used as: ```xml <plugin> <groupId>io.fabric8</groupId> <artifactId>docker-maven-plugin</artifactId> <version>${docker-maven-plugin.version}</version> <!-- now is 0.41.0 --> <configuration> <images> <image> <name>apache/shenyu-integrated-test-apache-dubbo</name> <!-- name with "repository"--> <build> <contextDir>${project.basedir}</contextDir> <!-- Dockerfile path --> </build> </image> </images> </configuration> <executions> <execution> <id>start</id> <goals> <goal>build</goal> </goals> </execution> </executions> </plugin> ``` ### Test on my PC Now I use Docker Desktop on Windows 10. And the result of plugin change are listed below. (I use 2 plugins to build docker images and corresponding sizes equal) I use this mvn command: ```shell mvn -B clean install -Pit -DskipTests -f ./shenyu-integrated-test/pom.xml ``` **use dockerfile-maven-plugin**:  **use docker-maven-plugin**:  ### Notice :warning: I only change packaging plugin in "integrated-test" in this PR now, for this is my first PR in apache/incubator-shenyu and I want to experience CI workflows (especially "it") for myself :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
