hutaishi commented on code in PR #3673:
URL: https://github.com/apache/incubator-shenyu/pull/3673#discussion_r915385082
##########
shenyu-web/src/main/java/org/apache/shenyu/web/handler/ShenyuWebHandler.java:
##########
@@ -105,7 +104,7 @@ public Mono<Void> handle(@NonNull final ServerWebExchange
exchange) {
*
* @param extPlugins the ext plugins
*/
- public void putExtPlugins(final List<ShenyuPlugin> extPlugins) {
+ public synchronized void putExtPlugins(final List<ShenyuPlugin>
extPlugins) {
Review Comment:
This method can be called without synchronized because it will not be called
concurrently, I remove this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
