dragon-zhang opened a new issue, #3805:
URL: https://github.com/apache/shenyu/issues/3805

   ### Description
   
   As a downstream of https://github.com/apache/shenyu/issues/3485, this task 
needs you to add(`do not delete any existing annotations`) more simpler client 
annotations.
   
   For example, below is how we use `client annotation` now:
   ```java
   @RestController
   @RequestMapping("/order")
   @ShenyuSpringCloudClient("/order")
   public class OrderController {
       
       @PostMapping("/save")
       @ShenyuSpringCloudClient("/save")
       public OrderDTO save(@RequestBody final OrderDTO orderDTO) {
           orderDTO.setName("hello world spring cloud save order");
           return orderDTO;
       }
   }
   ```
   Does it seem a little repetitive? We can realize combined annotation through 
`@AliasFor` and 
`org.springframework.core.annotation.AnnotatedElementUtils#findMergedAnnotation`.
   
   Notice: the newly added annotation needs to be compatible with all functions 
of other frameworks !
   
   Use simplified annotations like below:
   ```java
   @RestController
   @ShenyuRequestMapping("/order")
   public class OrderController {
       
       @ShenyuPostMapping("/save")
       public OrderDTO save(@RequestBody final OrderDTO orderDTO) {
           orderDTO.setName("hello world spring cloud save order");
           return orderDTO;
       }
   }
   ```
   
   ### Task List
   
   1. - [ ] add `@ShenyuRequestMapping`, `@ShenyuGetMapping`, 
`@ShenyuPostMapping`, `@ShenyuPutMapping`, `@ShenyuDeleteMapping`, 
`@ShenyuPatchMapping` for `shenyu-client-springmvc`;
   2. - [ ] add `@ShenyuRequestMapping`, `@ShenyuGetMapping`, 
`@ShenyuPostMapping`, `@ShenyuPutMapping`, `@ShenyuDeleteMapping`, 
`@ShenyuPatchMapping` for `shenyu-client-springcloud`;
   3. - [ ] add `@ShenyuService` for `shenyu-client-alibaba-dubbo`;
   4. - [ ] add `@ShenyuService`, `@ShenyuDubboService` for 
`shenyu-client-apache-dubbo`;


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to