dragon-zhang commented on code in PR #3851:
URL: https://github.com/apache/shenyu/pull/3851#discussion_r945813577


##########
shenyu-spring-boot-starter/shenyu-spring-boot-starter-client/shenyu-spring-boot-starter-client-motan/src/main/java/org/apache/shenyu/springboot/starter/client/motan/property/ShenyuMotanProperties.java:
##########
@@ -0,0 +1,246 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shenyu.springboot.starter.client.motan.property;
+
+/**
+ * Shenyu motan properties.
+ */
+public class ShenyuMotanProperties {
+
+    private ProtocolConfig protocolConfig = new ProtocolConfig();
+
+    private BasicServiceConfig basicServiceConfig = new BasicServiceConfig();
+
+    /**
+     * Get the protocol config.
+     * @return protocol config
+     */
+    public ProtocolConfig getProtocolConfig() {
+        return protocolConfig;
+    }
+
+    /**
+     * Set the protocol config.
+     * @param protocolConfig protocol config
+     */
+    public void setProtocolConfig(final ProtocolConfig protocolConfig) {
+        this.protocolConfig = protocolConfig;
+    }
+
+    /**
+     * Get the BasicServiceConfig.
+     * @return basicServiceConfig
+     */
+    public BasicServiceConfig getBasicServiceConfig() {
+        return basicServiceConfig;
+    }
+
+    /**
+     * Set the basicServiceConfig.
+     * @param basicServiceConfig basicServiceConfig
+     */
+    public void setBasicServiceConfig(final BasicServiceConfig 
basicServiceConfig) {
+        this.basicServiceConfig = basicServiceConfig;
+    }
+
+    public static class ProtocolConfig {

Review Comment:
   maybe it's better to simplify to `Protocol`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to