HeZean commented on PR #3891:
URL: https://github.com/apache/shenyu/pull/3891#issuecomment-1230489342

   Hi, I think I'm getting some trouble that I've searched but cannot resolve 
without submitting another PR to TarsJava.
   
   In [Tars's 
SpringBootAppContext.class](https://github.com/TarsCloud/TarsJava/blob/7550e165cd4a67637c333a21f99fbb7e169ca27d/spring/tars-spring-boot-starter/src/main/java/com/qq/tars/server/apps/SpringBootAppContext.java#L96),
 it uses `AnnotationUtils#getAnnotation` to get the `TarsServant` annotation, 
which will return `TarsServant{name = "", value = ""}` instead the one with 
aliased value. It should be changed to use 
`AnnotatedElementUtils#findMergedAnnotation`, this won't break its original 
capability.
   
   Should I submit a PR to TarsJava first? Any suggestions?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to