dragon-zhang commented on code in PR #3889:
URL: https://github.com/apache/shenyu/pull/3889#discussion_r958456261
##########
shenyu-examples/shenyu-examples-motan/shenyu-examples-motan-service/src/main/java/org/apache/shenyu/examples/motan/service/impl/MotanDemoServiceImpl.java:
##########
@@ -29,19 +28,18 @@
* <P>Default motan service name is "motan2", If you want to inject other
services,
* please refer to {@link ShenyuMotanClientConfiguration}
*/
-@ShenyuMotanService(export = "motan2:8002")
-@ShenyuMotanClient("/demoTest/**")
+@ShenyuMotanService(value = "/demoTest/**", export = "motan2:8002")
public class MotanDemoServiceImpl implements MotanDemoService {
@Override
- @ShenyuMotanClient("/hello")
+ @ShenyuMotanService(value = "/hello")
Review Comment:
should rollback.
##########
shenyu-examples/shenyu-examples-motan/shenyu-examples-motan-service/src/main/java/org/apache/shenyu/examples/motan/service/impl/MotanDemoServiceImpl.java:
##########
@@ -29,19 +28,18 @@
* <P>Default motan service name is "motan2", If you want to inject other
services,
* please refer to {@link ShenyuMotanClientConfiguration}
*/
-@ShenyuMotanService(export = "motan2:8002")
-@ShenyuMotanClient("/demoTest/**")
+@ShenyuMotanService(value = "/demoTest/**", export = "motan2:8002")
public class MotanDemoServiceImpl implements MotanDemoService {
@Override
- @ShenyuMotanClient("/hello")
+ @ShenyuMotanService(value = "/hello")
@Log
public String hello(final String name) {
return "hello " + name;
}
@Override
- @ShenyuMotanClient("/timeout")
+ @ShenyuMotanService(value = "/timeout")
Review Comment:
should rollback.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
