aFlyBird0 opened a new issue, #776:
URL: https://github.com/apache/shenyu-website/issues/776

   ## Fix
   The WebSocket settings can not work if user deploy ShenYu  under the guide 
of recent docs.
   
   Although we have created a network named `shenyu`, but the default 
configuration of `sync.websocket` is `127.0.0.1`.
   Therefor, `shenyu-bootstrap` can not access to `shenyu-admin`
   
   We could use `container-name` to visit other containers. 
   e.g. execute `ping shenyu-admin` in `shenyu-bootstrap` container is OK.
   
   The deployment of `docker-compose` is a good example:
   
   
https://github.com/apache/shenyu/blob/2065b71c871b3e94439df5c85314e9234f9f181a/shenyu-dist/shenyu-docker-compose-dist/src/main/resources/docker-compose.yaml#L31
   
   ## Enhancement
   
   1. Some commands are too long to read
   
   such as:
   
   ```shell
   docker run -v ${your_work_dir}/conf:/opt/shenyu-admin/conf -d -p 9095:9095 
--net shenyu apache/shenyu-admin:${current.version}
   ```
   
   I think this way is better to read:
   
   ```shell
   docker run -d \
     -v ${your_work_dir}/conf:/opt/shenyu-admin/conf \
     -p 9095:9095 
     --net shenyu 
     apache/shenyu-admin:${current.version}
     ${shenyu-admin-container-name}
   ```
   
   2. use shell variables
   
   There are to many `${current.version}` in the doc, why not
   
   ```shell
   export current_version=latest # then reuse this var so that user need not to 
change the command every time
   docker pull apache/shenyu-admin${current_version}
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to