leopardrota commented on code in PR #3838:
URL: https://github.com/apache/shenyu/pull/3838#discussion_r985545189
##########
shenyu-examples/shenyu-examples-dubbo/shenyu-examples-apache-dubbo-service-annotation/src/main/java/org/apache/shenyu/examples/apache/dubbo/service/annotation/impl/DubboTestServiceImpl.java:
##########
@@ -34,7 +34,7 @@
/**
* The type Dubbo service.
*/
-@DubboService
+@ShenyuDubboService("demo")
public class DubboTestServiceImpl implements DubboTestService {
Review Comment:
Why did not this be rollbacked? It seems that Dubbo only resolves the direct
annotation, not composite annotation.
##########
shenyu-examples/shenyu-examples-dubbo/shenyu-examples-apache-dubbo-service-annotation/src/main/java/org/apache/shenyu/examples/apache/dubbo/service/annotation/impl/DubboTestServiceImpl.java:
##########
@@ -34,7 +34,7 @@
/**
* The type Dubbo service.
*/
-@DubboService
+@ShenyuDubboService("demo")
public class DubboTestServiceImpl implements DubboTestService {
Review Comment:
Why did this not be rollbacked? It seems that Dubbo only resolves the direct
annotation, not composite annotation.
##########
shenyu-examples/shenyu-examples-dubbo/shenyu-examples-apache-dubbo-service-annotation/src/main/java/org/apache/shenyu/examples/apache/dubbo/service/annotation/impl/DubboMultiParamServiceImpl.java:
##########
@@ -32,7 +32,7 @@
/**
* The type Dubbo multi param service.
*/
-@DubboService
+@ShenyuDubboService("demo")
Review Comment:
Why did this not be rollbacked? It seems that Dubbo only resolves the
direct annotation, not composite annotation. (#4031)
##########
shenyu-examples/shenyu-examples-dubbo/shenyu-examples-apache-dubbo-service-annotation/src/main/java/org/apache/shenyu/examples/apache/dubbo/service/annotation/impl/DubboTestServiceImpl.java:
##########
@@ -34,7 +34,7 @@
/**
* The type Dubbo service.
*/
-@DubboService
+@ShenyuDubboService("demo")
public class DubboTestServiceImpl implements DubboTestService {
Review Comment:
Why is this not rollbacked? It seems that Dubbo only resolves the direct
annotation, not composite annotation.
##########
shenyu-examples/shenyu-examples-dubbo/shenyu-examples-apache-dubbo-service-annotation/src/main/java/org/apache/shenyu/examples/apache/dubbo/service/annotation/impl/DubboTestServiceImpl.java:
##########
@@ -34,7 +34,7 @@
/**
* The type Dubbo service.
*/
-@DubboService
+@ShenyuDubboService("demo")
public class DubboTestServiceImpl implements DubboTestService {
Review Comment:
Why was this not rollbacked? It seems that Dubbo only resolves the direct
annotation, not composite annotation.
##########
shenyu-examples/shenyu-examples-dubbo/shenyu-examples-apache-dubbo-service-annotation/src/main/java/org/apache/shenyu/examples/apache/dubbo/service/annotation/impl/DubboMultiParamServiceImpl.java:
##########
@@ -32,7 +32,7 @@
/**
* The type Dubbo multi param service.
*/
-@DubboService
+@ShenyuDubboService("demo")
Review Comment:
Why was this not rollbacked? It seems that Dubbo only resolves the direct
annotation, not composite annotation. (#4031)
##########
shenyu-examples/shenyu-examples-dubbo/shenyu-examples-spring-cloud-alibaba-dubbo-service-annotation/src/main/java/org/apache/shenyu/examples/spring/cloud/dubbo/service/annotation/impl/MultiParamServiceImpl.java:
##########
@@ -32,7 +32,7 @@
/**
* The type Dubbo multi param service.
*/
-@DubboService
+@ShenyuDubboService("demo")
Review Comment:
Why was this not rollbacked? It seems that Dubbo only resolves the direct
annotation, not composite annotation.
##########
shenyu-examples/shenyu-examples-dubbo/shenyu-examples-spring-cloud-alibaba-dubbo-service-annotation/src/main/java/org/apache/shenyu/examples/spring/cloud/dubbo/service/annotation/impl/TestServiceImpl.java:
##########
@@ -30,7 +30,7 @@
/**
* The type Dubbo service.
*/
-@DubboService
+@ShenyuDubboService("test")
Review Comment:
Why was this not rollbacked? It seems that Dubbo only resolves the direct
annotation, not composite annotation.
##########
shenyu-examples/shenyu-examples-dubbo/shenyu-examples-apache-dubbo-service-annotation/src/main/java/org/apache/shenyu/examples/apache/dubbo/service/annotation/impl/DubboMultiParamServiceImpl.java:
##########
@@ -32,7 +32,7 @@
/**
* The type Dubbo multi param service.
*/
-@DubboService
+@ShenyuDubboService("demo")
Review Comment:
Why was this not rollbacked? It seems that Dubbo only resolves the direct
annotation, not composite annotation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
