wulangcode opened a new issue, #4147:
URL: https://github.com/apache/shenyu/issues/4147

   ### Description
   
   `ApacheDubboConfigCache#needUpdateRegistryConfig`redundant code exists
   ```java
       private boolean needUpdateRegistryConfig(final DubboRegisterConfig 
dubboRegisterConfig) {
           if (Objects.isNull(registryConfig)) {
               return true;
           }
           return !Objects.equals(dubboRegisterConfig.getProtocol(), 
registryConfig.getProtocol())
                   || !Objects.equals(dubboRegisterConfig.getRegister(), 
registryConfig.getAddress())
                   || !Objects.equals(dubboRegisterConfig.getProtocol(), 
registryConfig.getProtocol());
       }
   ```
    I'll finish it later.
   
   ### Task List
   
   1. Delete redundant code


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to