gngsn opened a new pull request, #4170:
URL: https://github.com/apache/shenyu/pull/4170

   <!-- Describe your PR here; eg. Fixes #issueNo -->
   When requesting with request parameters sandbox API has a json parser error 
because translates the object to json twice. 
   In the below picture, you can see that is passing `reqJson` to 
`JsonUtils.toMap`, but `toMap` method translates the object to json again. 
   
   <img width="1792" alt="스크린샷 2022-11-09 오후 10 18 36" 
src="https://user-images.githubusercontent.com/43839834/200974467-a9866fb4-06b9-4f75-badc-1bd7728f328c.png";>
   <img width="1792" alt="스크린샷 2022-11-09 오후 10 19 57" 
src="https://user-images.githubusercontent.com/43839834/200974958-4a44f4b7-8901-46be-a741-a8a273773383.png";>
   
   <br/>
   
   + All logic implement in Controller layer, so I arrange the logic by moving 
to Service layer.
   
   <br/><br/>
   
   <!--
   Thank you for proposing a pull request. This template will guide you through 
the essential steps necessary for a pull request.
   -->
   Make sure that:
   
   - [x] You have read the [contribution 
guidelines](https://shenyu.apache.org/community/contributor-guide).
   - [x] You submit test cases (unit or integration tests) that back your 
changes.
   - [x] Your local test passed `./mvnw clean install 
-Dmaven.javadoc.skip=true`.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to