tian-pengfei commented on code in PR #4236:
URL: https://github.com/apache/shenyu/pull/4236#discussion_r1040442434
##########
shenyu-plugin/shenyu-plugin-mock/src/main/java/org/apache/shenyu/plugin/mock/generator/ExpressionGenerator.java:
##########
@@ -49,8 +47,10 @@ public String getName() {
public String doGenerate(final List<String> params, final String rule,
final MockRequest mockRequest) {
String expression = params.get(0);
- CONTEXT.setVariable("req", mockRequest);
- Object val = PARSER.parseExpression(expression).getValue(CONTEXT);
+ EvaluationContext context = initContext();
Review Comment:
you mean ,thread safety is not required here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
