This is an automated email from the ASF dual-hosted git repository.
likeguo pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shenyu.git
The following commit(s) were added to refs/heads/master by this push:
new 14bc2bd50 perf: replace `Collection.size()` with `isEmpty` (#4245)
14bc2bd50 is described below
commit 14bc2bd50cbcbdf3fd61ed5253c09a4746cbca17
Author: youzipi <[email protected]>
AuthorDate: Thu Dec 8 23:03:37 2022 +0800
perf: replace `Collection.size()` with `isEmpty` (#4245)
---
.../apache/shenyu/admin/service/impl/UpstreamCheckService.java | 8 ++++----
.../shenyu/admin/service/manager/impl/SwaggerDocParser.java | 2 +-
.../src/main/java/org/apache/shenyu/admin/utils/HttpUtils.java | 2 +-
.../test/java/org/apache/shenyu/common/enums/PluginEnumTest.java | 2 +-
.../apache/shenyu/loadbalancer/cache/UpstreamCheckTaskTest.java | 2 +-
.../org/apache/shenyu/sync/data/http/HttpSyncDataService.java | 2 +-
6 files changed, 9 insertions(+), 9 deletions(-)
diff --git
a/shenyu-admin/src/main/java/org/apache/shenyu/admin/service/impl/UpstreamCheckService.java
b/shenyu-admin/src/main/java/org/apache/shenyu/admin/service/impl/UpstreamCheckService.java
index 78503c8cc..f512654c9 100644
---
a/shenyu-admin/src/main/java/org/apache/shenyu/admin/service/impl/UpstreamCheckService.java
+++
b/shenyu-admin/src/main/java/org/apache/shenyu/admin/service/impl/UpstreamCheckService.java
@@ -243,10 +243,10 @@ public class UpstreamCheckService {
private void scheduled() {
try {
- if (ZOMBIE_SET.size() > 0) {
+ if (!ZOMBIE_SET.isEmpty()) {
ZOMBIE_SET.parallelStream().forEach(this::checkZombie);
}
- if (UPSTREAM_MAP.size() > 0) {
+ if (!UPSTREAM_MAP.isEmpty()) {
UPSTREAM_MAP.forEach(this::check);
}
} catch (Exception e) {
@@ -297,11 +297,11 @@ public class UpstreamCheckService {
private void updateHandler(final String selectorId, final
List<CommonUpstream> upstreamList, final List<CommonUpstream> successList) {
//No node changes, including zombie node resurrection and live node
death
- if (successList.size() == upstreamList.size() && PENDING_SYNC.size()
== 0) {
+ if (successList.size() == upstreamList.size() &&
PENDING_SYNC.isEmpty()) {
return;
}
removePendingSync(successList);
- if (successList.size() > 0) {
+ if (!successList.isEmpty()) {
UPSTREAM_MAP.put(selectorId, successList);
updateSelectorHandler(selectorId, successList);
} else {
diff --git
a/shenyu-admin/src/main/java/org/apache/shenyu/admin/service/manager/impl/SwaggerDocParser.java
b/shenyu-admin/src/main/java/org/apache/shenyu/admin/service/manager/impl/SwaggerDocParser.java
index 76a3ed43e..953d823d5 100755
---
a/shenyu-admin/src/main/java/org/apache/shenyu/admin/service/manager/impl/SwaggerDocParser.java
+++
b/shenyu-admin/src/main/java/org/apache/shenyu/admin/service/manager/impl/SwaggerDocParser.java
@@ -169,7 +169,7 @@ public class SwaggerDocParser implements DocParser {
protected String buildModuleName(final JsonObject docInfo, final
JsonObject docRoot, final String basePath) {
JsonArray tags = docInfo.getAsJsonArray("tags");
- if (Objects.nonNull(tags) && tags.size() > 0) {
+ if (Objects.nonNull(tags) && !tags.isEmpty()) {
return tags.get(0).getAsString();
}
return
Optional.ofNullable(docRoot.getAsJsonObject("info")).map(jsonObject ->
jsonObject.get("title").getAsString()).orElse(basePath);
diff --git
a/shenyu-admin/src/main/java/org/apache/shenyu/admin/utils/HttpUtils.java
b/shenyu-admin/src/main/java/org/apache/shenyu/admin/utils/HttpUtils.java
index 1f0cdb199..39309edab 100644
--- a/shenyu-admin/src/main/java/org/apache/shenyu/admin/utils/HttpUtils.java
+++ b/shenyu-admin/src/main/java/org/apache/shenyu/admin/utils/HttpUtils.java
@@ -302,7 +302,7 @@ public class HttpUtils {
*/
public Response requestCall(final String url, final Map<String, ?> form,
final Map<String, String> header,
final HTTPMethod method, final List<UploadFile> files) throws
IOException {
- if (Objects.nonNull(files) && files.size() > 0) {
+ if (Objects.nonNull(files) && !files.isEmpty()) {
return requestFile(url, form, header, files);
} else {
return requestForResponse(url, form, header, method);
diff --git
a/shenyu-common/src/test/java/org/apache/shenyu/common/enums/PluginEnumTest.java
b/shenyu-common/src/test/java/org/apache/shenyu/common/enums/PluginEnumTest.java
index 516ba9ac1..03efac4c4 100644
---
a/shenyu-common/src/test/java/org/apache/shenyu/common/enums/PluginEnumTest.java
+++
b/shenyu-common/src/test/java/org/apache/shenyu/common/enums/PluginEnumTest.java
@@ -43,7 +43,7 @@ public final class PluginEnumTest {
@Test
public void testGetUpstreamNames() {
List<String> list = PluginEnum.getUpstreamNames();
- assert list.size() > 0;
+ assert !list.isEmpty();
}
@Test
diff --git
a/shenyu-loadbalancer/src/test/java/org/apache/shenyu/loadbalancer/cache/UpstreamCheckTaskTest.java
b/shenyu-loadbalancer/src/test/java/org/apache/shenyu/loadbalancer/cache/UpstreamCheckTaskTest.java
index 0c0bf9e12..84d4b7ec1 100644
---
a/shenyu-loadbalancer/src/test/java/org/apache/shenyu/loadbalancer/cache/UpstreamCheckTaskTest.java
+++
b/shenyu-loadbalancer/src/test/java/org/apache/shenyu/loadbalancer/cache/UpstreamCheckTaskTest.java
@@ -88,7 +88,7 @@ public class UpstreamCheckTaskTest {
// Manually run one time
healthCheckTask.run();
Awaitility.await().pollDelay(1, TimeUnit.SECONDS).untilAsserted(() ->
assertFalse(healthCheckTask.getCheckStarted().get()));
-
assertTrue(healthCheckTask.getHealthyUpstream().get(selectorId1).size() > 0);
+
assertFalse(healthCheckTask.getHealthyUpstream().get(selectorId1).isEmpty());
healthCheckTask.print();
}
diff --git
a/shenyu-sync-data-center/shenyu-sync-data-http/src/main/java/org/apache/shenyu/sync/data/http/HttpSyncDataService.java
b/shenyu-sync-data-center/shenyu-sync-data-http/src/main/java/org/apache/shenyu/sync/data/http/HttpSyncDataService.java
index 237e9a207..7a360b399 100644
---
a/shenyu-sync-data-center/shenyu-sync-data-http/src/main/java/org/apache/shenyu/sync/data/http/HttpSyncDataService.java
+++
b/shenyu-sync-data-center/shenyu-sync-data-http/src/main/java/org/apache/shenyu/sync/data/http/HttpSyncDataService.java
@@ -194,7 +194,7 @@ public class HttpSyncDataService implements SyncDataService
{
throw new ShenyuException(message, e);
}
- if (Objects.nonNull(groupJson) && groupJson.size() > 0) {
+ if (Objects.nonNull(groupJson) && !groupJson.isEmpty()) {
// fetch group configuration async.
ConfigGroupEnum[] changedGroups =
GsonUtils.getGson().fromJson(groupJson, ConfigGroupEnum[].class);
LOG.info("Group config changed: {}",
Arrays.toString(changedGroups));
