[GitHub] [shenyu] RayayChung commented on a diff in pull request #4260: [ISSUE #4243] to avoid load the same ext plugins repeatedly

Mon, 12 Dec 2022 19:28:23 -0800 


RayayChung commented on code in PR #4260:
URL: https://github.com/apache/shenyu/pull/4260#discussion_r1046623644


##########
shenyu-web/src/main/java/org/apache/shenyu/web/loader/ShenyuPluginLoader.java:
##########
@@ -106,7 +99,12 @@ public List<ShenyuLoaderResult> loadExtendPlugins(final 
String path) throws IOEx
             return Collections.emptyList();
         }
         List<ShenyuLoaderResult> results = new ArrayList<>();
+        boolean loadNewPlugin = false;
         for (File each : jarFiles) {
+            if 
(jars.stream().map(PluginJar::absolutePath).filter(StringUtils::hasText).anyMatch(p
 -> p.equals(each.getAbsolutePath()))) {

Review Comment:
   Base on `v2.5.0`, the plugin of new version with the same absolutePath will 
also not be loaded if the className is not changed. 
   
![image](https://user-images.githubusercontent.com/15926669/207218707-496b31b6-8c1c-4d59-a1de-bfe987f96615.png)
   If we want to handle this,  should we make a new feature to solve it?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to