dragon-zhang commented on code in PR #4270:
URL: https://github.com/apache/shenyu/pull/4270#discussion_r1051332803
##########
shenyu-client/shenyu-client-sofa/src/main/java/org/apache/shenyu/client/sofa/SofaServiceEventListener.java:
##########
@@ -151,6 +159,44 @@ public void onApplicationEvent(final ContextRefreshedEvent
contextRefreshedEvent
}
}
+ @Override
+ protected List<ApiDocRegisterDTO> buildApiDocDTO(final Class<?> clazz,
final Method method) {
+ final String contextPath = getContextPath();
+ String apiDesc =
Stream.of(method.getDeclaredAnnotations()).filter(item -> item instanceof
ApiDoc).findAny().map(item -> {
+ ApiDoc apiDoc = (ApiDoc) item;
+ return apiDoc.desc();
+ }).orElse("");
+ String superPath = buildApiSuperPath(clazz,
AnnotatedElementUtils.findMergedAnnotation(clazz, getAnnotationType()));
+ if (superPath.indexOf("*") > 0) {
+ superPath = superPath.substring(0, superPath.lastIndexOf("/"));
+ }
+ ShenyuSofaClient shenyuSofaClient =
AnnotatedElementUtils.findMergedAnnotation(method, ShenyuSofaClient.class);
+ if (Objects.isNull(shenyuSofaClient)) {
+ return Lists.newArrayList();
+ }
+ List<ApiDocRegisterDTO> list = Lists.newArrayList();
+ String value = shenyuSofaClient.value();
+ String apiPath = contextPath + superPath + value;
+ ApiDocRegisterDTO build = ApiDocRegisterDTO.builder()
+ .consume(ShenyuClientConstants.MEDIA_TYPE_ALL_VALUE)
+ .produce(ShenyuClientConstants.MEDIA_TYPE_ALL_VALUE)
+ .httpMethod(ApiHttpMethodEnum.NOT_HTTP.getValue())
Review Comment:
I have seen a lot of similar code. Can you use template method pattern to
abstract another parent class? The new abstract class extends from
`AbstractContextRefreshedEventListener`, and `SofaServiceEventListener` extends
from the new abstract class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
