li-keguo commented on code in PR #4359:
URL: https://github.com/apache/shenyu/pull/4359#discussion_r1105881944
##########
shenyu-plugin/shenyu-plugin-oauth2/src/main/java/org/apache/shenyu/plugin/oauth2/OAuth2Plugin.java:
##########
@@ -70,8 +68,8 @@ public String named() {
@Override
public boolean skip(final ServerWebExchange exchange) {
- Boolean skipStatus = exchange.<Boolean>getAttribute(OAUTH2_ENABLE);
- return skipStatus == null || skipStatus;
+ Boolean skipStatus = exchange.<Boolean>getAttribute("enable");
+ return skipStatus == null || !skipStatus;
Review Comment:
`!Boolean.TRUE.equals(exchange.getAttribute("enable"))`
not enable is skip.
That might make the meaning clearer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
