JooKS-me commented on code in PR #4831:
URL: https://github.com/apache/shenyu/pull/4831#discussion_r1291526315
##########
shenyu-spring-boot-starter/shenyu-spring-boot-starter-k8s/src/main/java/org/apache/shenyu/springboot/starter/k8s/IngressControllerConfiguration.java:
##########
@@ -158,11 +159,12 @@ public EndpointsReconciler endpointsReconciler(final
SharedIndexInformer<V1Ingre
* ShenyuCacheRepository.
*
* @param subscriber PluginDataSubscriber
+ * @param metaDataSubscriber CommonMetaDataSubscriber
* @return ShenyuCacheRepository
*/
@Bean
- public ShenyuCacheRepository shenyuCacheRepository(final
PluginDataSubscriber subscriber) {
- return new ShenyuCacheRepository(subscriber);
+ public ShenyuCacheRepository shenyuCacheRepository(final
PluginDataSubscriber subscriber, final CommonMetaDataSubscriber
metaDataSubscriber) {
+ return new ShenyuCacheRepository(subscriber, metaDataSubscriber);
Review Comment:
```suggestion
return new ShenyuCacheRepository(pluginDataSubscriber,
metaDataSubscriber);
```
##########
shenyu-kubernetes-controller/src/main/java/org/apache/shenyu/k8s/common/IngressConstants.java:
##########
@@ -37,4 +39,23 @@ public class IngressConstants {
// The maximum length of the request header, in bytes
public static final String REQUEST_MAX_SIZE_ANNOTATION_KEY =
"shenyu.apache.org/request-max-size";
+
+ //Determine if the dubbo plugin is enabled, in bool
+ public static final String PLUGIN_DUBBO_ENABLED =
"shenyu.apache.org/plugin-dubbo-enabled";
+
+ public static final String PLUGIN_DUBBO_APP_NAME =
"shenyu.apache.org/plugin-dubbo-app-name";
Review Comment:
Add node for this.
##########
shenyu-kubernetes-controller/src/main/java/org/apache/shenyu/k8s/repository/ShenyuCacheRepository.java:
##########
@@ -37,13 +40,16 @@ public class ShenyuCacheRepository {
private final PluginDataSubscriber subscriber;
Review Comment:
```suggestion
private final PluginDataSubscriber pluginDataSubscriber;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
