kerwin612 commented on code in PR #4983: URL: https://github.com/apache/shenyu/pull/4983#discussion_r1294076624
########## db/upgrade/2.6.0-upgrade-2.6.1-mysql.sql: ########## @@ -0,0 +1,19 @@ +-- Licensed to the Apache Software Foundation (ASF) under one +-- or more contributor license agreements. See the NOTICE file +-- distributed with this work for additional information +-- regarding copyright ownership. The ASF licenses this file +-- to you under the Apache License, Version 2.0 (the +-- "License"); you may not use this file except in compliance +-- with the License. You may obtain a copy of the License at +-- +-- http://www.apache.org/licenses/LICENSE-2.0 +-- Review Comment: According to the rules I see, the released version is 2.6.0, and the development version is 2.6.1; So my new fields are in 2.6.0-upgrade-2.6.1-xxx.sql, isn't that right? > copy new sql named 2.6.1 from 2.6.0.sql, and add these fields to 2.6.1.sql and 2.6.0-to-2.6.1.sql You mean: ``` ... 2.5.1-upgrade-2.6.0-xxx.sql 2.6.0-upgrade-2.6.1-xxx.sql (the new file added by the current PR) 2.6.1-xxx.sql (???, copy new sql named 2.6.1 from 2.6.0.sql) ``` The contents of **2.6.1-xxx.sql** and **2.6.0-upgrade-2.6.1-xxx.sql** are the same, and MD5 is the same. Is that what it means? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
