runqi-zhao commented on code in PR #5054:
URL: https://github.com/apache/shenyu/pull/5054#discussion_r1300964965


##########
shenyu-kubernetes-controller/src/main/java/org/apache/shenyu/k8s/parser/DubboIngressParser.java:
##########
@@ -292,7 +292,7 @@ private List<DubboUpstream> parseUpstream(final 
V1IngressBackend backend, final
                         DubboUpstream upstream = DubboUpstream.builder()
                                 .upstreamUrl(clusterIP + ":" + defaultPort)
                                 .weight(100)
-                                .protocol("http://";)
+                                .protocol("dubbo://")

Review Comment:
   Users cannot set their own protocols for the time being.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to