moremind commented on code in PR #5530:
URL: https://github.com/apache/shenyu/pull/5530#discussion_r1565176871
##########
shenyu-admin/src/main/java/org/apache/shenyu/admin/transfer/DiscoveryTransfer.java:
##########
@@ -187,16 +213,19 @@ public DiscoveryUpstreamData
mapToData(DiscoveryUpstreamDTO discoveryUpstreamDTO
* @return ProxySelectorData
*/
public ProxySelectorData mapToData(ProxySelectorDTO proxySelectorDTO) {
- ProxySelectorData proxySelectorData = new ProxySelectorData();
- proxySelectorData.setId(proxySelectorDTO.getId());
- proxySelectorData.setName(proxySelectorDTO.getName());
- proxySelectorData.setPluginName(proxySelectorDTO.getPluginName());
- proxySelectorData.setType(proxySelectorDTO.getType());
- proxySelectorData.setForwardPort(proxySelectorDTO.getForwardPort());
- String props = proxySelectorDTO.getProps();
- Properties properties = GsonUtils.getInstance().fromJson(props,
Properties.class);
- proxySelectorData.setProps(properties);
- return proxySelectorData;
+ return Optional.ofNullable(proxySelectorDTO).map(data -> {
+ ProxySelectorData proxySelectorData = new ProxySelectorData();
+ proxySelectorData.setId(data.getId());
+ proxySelectorData.setName(data.getName());
+ proxySelectorData.setPluginName(data.getPluginName());
+ proxySelectorData.setType(data.getType());
+ proxySelectorData.setForwardPort(data.getForwardPort());
+ String props = data.getProps();
+ Properties properties = GsonUtils.getInstance().fromJson(props,
Properties.class);
+ proxySelectorData.setProps(properties);
+ return proxySelectorData;
+ })
+ .orElse(null);
Review Comment:
not change line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
