[I] [BUG] In rulesList, The un-matching request will cause normal requests to fail [shenyu]</span></a></span> </h1> <p class="darkgray font13"> <span class="sender pipe"><a href="/search?l=notifications@shenyu.apache.org&q=from:%22via+GitHub%22" rel="nofollow"><span itemprop="author" itemscope itemtype="http://schema.org/Person"><span itemprop="name">via GitHub</span></span></a></span> <span class="date"><a href="/search?l=notifications@shenyu.apache.org&q=date:20240704" rel="nofollow">Thu, 04 Jul 2024 01:49:06 -0700</a></span> </p> </div> <div itemprop="articleBody" class="msgBody"> <!--X-Body-of-Message--> <pre> creabob opened a new issue, #5588: URL: <a rel="nofollow" href="https://github.com/apache/shenyu/issues/5588">https://github.com/apache/shenyu/issues/5588</a></pre><pre> ### Is there an existing issue for this? - [X] I have searched the existing issues ### Current Behavior this is my rule setting in modifyResponse plugin <img width="841" alt="image" src="<a rel="nofollow" href="https://github.com/apache/shenyu/assets/25314080/eef719a3-9a55-400e-8986-e37b25e2e699"">https://github.com/apache/shenyu/assets/25314080/eef719a3-9a55-400e-8986-e37b25e2e699"</a>;> this is matching case <img width="483" alt="image" src="<a rel="nofollow" href="https://github.com/apache/shenyu/assets/25314080/df23f8ff-605b-4daf-9a54-842e44b7280c"">https://github.com/apache/shenyu/assets/25314080/df23f8ff-605b-4daf-9a54-842e44b7280c"</a>;> this is un-matching case without add body info <img width="469" alt="image" src="<a rel="nofollow" href="https://github.com/apache/shenyu/assets/25314080/122ead6e-39e6-4e14-a094-5d93828e9781"">https://github.com/apache/shenyu/assets/25314080/122ead6e-39e6-4e14-a094-5d93828e9781"</a>;> but after un-matching case, the matching case become un-match <img width="535" alt="image" src="<a rel="nofollow" href="https://github.com/apache/shenyu/assets/25314080/0122b18b-57c1-486a-b4c5-8473a3341d82"">https://github.com/apache/shenyu/assets/25314080/0122b18b-57c1-486a-b4c5-8473a3341d82"</a>;> this operates in orders ### Expected Behavior Whenever the request happens, the matching scene should be matched ### Steps To Reproduce 1. in shenyu-master branch 2. set matching rules 3. happen one un-matching case 4. matching case will dismatch ### Environment ```markdown ShenYu version(s): master ``` ### Debug logs this is the logs under matching case but un-matching and without modifyResponse rule success match info. <img width="703" alt="image" src="<a rel="nofollow" href="https://github.com/apache/shenyu/assets/25314080/995c5b05-04c9-4299-816d-0ba65701860a"">https://github.com/apache/shenyu/assets/25314080/995c5b05-04c9-4299-816d-0ba65701860a"</a>;> ### Anything else? i have debug in this case, find some questions in this line, why caches an empty ruleData when not match rules. <img width="1013" alt="image" src="<a rel="nofollow" href="https://github.com/apache/shenyu/assets/25314080/206854c5-480a-4dd1-9dc5-aec0be65ce23"">https://github.com/apache/shenyu/assets/25314080/206854c5-480a-4dd1-9dc5-aec0be65ce23"</a>;> `cacheRuleData(path, emptyRuleData);` when i delete this line ,this bug will be fixed. but i am not sure this operate is correct. Can u introduce the original intention of this line which cache empty ruleData? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@shenyu.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org </pre> </div> <div class="msgButtons margintopdouble"> <ul class="overflow"> <li class="msgButtonItems"><a class="button buttonleft " accesskey="p" href="msg30672.html">Previous message</a></li> <li class="msgButtonItems textaligncenter"><a class="button" accesskey="c" href="index.html#30674">View by thread</a></li> <li class="msgButtonItems textaligncenter"><a class="button" accesskey="i" href="maillist.html#30674">View by date</a></li> <li class="msgButtonItems textalignright"><a class="button buttonright " accesskey="n" href="msg30675.html">Next message</a></li> </ul> </div> <a name="tslice"></a> <div class="tSliceList margintopdouble"> <ul class="icons monospace"> <li class="icons-email tSliceCur"><span class="subject">[I] [BUG] <title> In rulesList, The un-matching request w...</span> <span class="sender italic">via GitHub</span></li> <li><ul> <li class="icons-email"><span class="subject"><a href="msg30675.html">Re: [I] [BUG] <title> In rulesList, The un-matching ...</a></span> <span class="sender italic">via GitHub</span></li> <li class="icons-email"><span class="subject"><a href="msg30679.html">Re: [I] [BUG] <title> In rulesList, The un-matching ...</a></span> <span class="sender italic">via GitHub</span></li> <li class="icons-email"><span class="subject"><a href="msg30681.html">Re: [I] [BUG] <title> In rulesList, The un-matching ...</a></span> <span class="sender italic">via GitHub</span></li> <li class="icons-email"><span class="subject"><a href="msg30691.html">Re: [I] [BUG] <title> In rulesList, The un-matching ...</a></span> <span class="sender italic">via GitHub</span></li> <li class="icons-email"><span class="subject"><a href="msg30728.html">Re: [I] [BUG] <title> In rulesList, The un-matching ...</a></span> <span class="sender italic">via GitHub</span></li> <li class="icons-email"><span class="subject"><a href="msg30739.html">Re: [I] [BUG] <title> In rulesList, The un-matching ...</a></span> <span class="sender italic">via GitHub</span></li> <li class="icons-email"><span class="subject"><a href="msg30743.html">Re: [I] [BUG] <title> In rulesList, The un-matching ...</a></span> <span class="sender italic">via GitHub</span></li> </ul> </ul> </div> <div class="overflow msgActions margintopdouble"> <div class="msgReply" > <h2> Reply via email to </h2> <form method="POST" action="/mailto.php"> <input type="hidden" name="subject" value="[I] [BUG] <title> In rulesList, The un-matching request will cause normal requests to fail [shenyu]"> <input type="hidden" name="msgid" value="I_kwDOCGCHjs6OeS8j@gitbox.apache.org"> <input type="hidden" name="relpath" value="notifications@shenyu.apache.org/msg30674.html"> <input type="submit" value=" via GitHub "> </form> </div> </div> </div> <div class="aside" role="complementary"> <div class="logo"> <a href="/"><img src="/logo.png" width=247 height=88 alt="The Mail Archive"></a> </div> <form class="overflow" action="/search" method="get"> <input type="hidden" name="l" value="notifications@shenyu.apache.org"> <label class="hidden" for="q">Search the site</label> <input class="submittext" type="text" id="q" name="q" placeholder="Search notifications"> <input class="submitbutton" name="submit" type="image" src="/submit.png" alt="Submit"> </form> <div class="nav margintop" id="nav" role="navigation"> <ul class="icons font16"> <li class="icons-home"><a href="/">The Mail Archive home</a></li> <li class="icons-list"><a href="/notifications@shenyu.apache.org/">notifications - all messages</a></li> <li class="icons-about"><a href="/notifications@shenyu.apache.org/info.html">notifications - about the list</a></li> <li class="icons-expand"><a href="/search?l=notifications@shenyu.apache.org&q=subject:%22%5C%5BI%5C%5D+%5C%5BBUG%5C%5D+%3Ctitle%3E+In+rulesList%2C+The+un%5C-matching+request+will+cause+normal+requests+to+fail++%5C%5Bshenyu%5C%5D%22&o=newest&f=1" title="e" id="e">Expand</a></li> <li class="icons-prev"><a href="msg30672.html" title="p">Previous message</a></li> <li class="icons-next"><a href="msg30675.html" title="n">Next message</a></li> </ul> </div> <div class="listlogo margintopdouble"> </div> <div class="margintopdouble"> </div> </div> </div> <div class="footer" role="contentinfo"> <ul> <li><a href="/">The Mail Archive home</a></li> <li><a href="/faq.html#newlist">Add your mailing list</a></li> <li><a href="/faq.html">FAQ</a></li> <li><a href="/faq.html#support">Support</a></li> <li><a href="/faq.html#privacy">Privacy</a></li> <li class="darkgray">I_kwDOCGCHjs6OeS8j@gitbox.apache.org</li> </ul> </div> </body> </html>