xcsnx commented on code in PR #5584:
URL: https://github.com/apache/shenyu/pull/5584#discussion_r1669770682


##########
shenyu-admin/src/main/java/org/apache/shenyu/admin/controller/PluginController.java:
##########
@@ -185,36 +185,7 @@ public ShenyuAdminResult enabled(@Valid @RequestBody final 
BatchCommonDTO batchC
         }
         return ShenyuAdminResult.success(ShenyuResultMessage.ENABLE_SUCCESS);
     }
-    
-    /**
-     * sync plugins.
-     *
-     * @return {@linkplain ShenyuAdminResult}
-     */
-    @PostMapping("/syncPluginAll")
-    @RequiresPermissions("system:plugin:modify")
-    public ShenyuAdminResult syncPluginAll() {
-        boolean success = syncDataService.syncAll(DataEventTypeEnum.REFRESH);
-        if (success) {

Review Comment:
   Because the plugin will be configured as a template, this syncPluginAll 
method has been moved to the pluginNamespace controller



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to