moremind commented on code in PR #5593:
URL: https://github.com/apache/shenyu/pull/5593#discussion_r1669751537
##########
shenyu-admin/src/main/java/org/apache/shenyu/admin/mode/cluster/filter/ClusterForwardFilter.java:
##########
@@ -57,39 +57,67 @@ public class ClusterForwardFilter extends
OncePerRequestFilter {
private static final PathMatcher PATH_MATCHER = new AntPathMatcher();
- @Resource
- private RestTemplate restTemplate;
+ private final RestTemplate restTemplate;
Review Comment:
not use rest template
##########
shenyu-admin/src/main/java/org/apache/shenyu/admin/config/ClusterConfiguration.java:
##########
@@ -69,11 +71,15 @@ public ShenyuRunningModeService
shenyuRunningModeService(final ClusterSelectMast
/**
* Shenyu cluster forward filter.
*
+ * @param clusterProperties cluster properties
* @return the Shenyu cluster forward filter
*/
@Bean
- public ClusterForwardFilter clusterForwardFilter() {
- return new ClusterForwardFilter();
+ public ClusterForwardFilter clusterForwardFilter(final ClusterProperties
clusterProperties) {
+ SimpleClientHttpRequestFactory factory = new
SimpleClientHttpRequestFactory();
+ factory.setConnectTimeout(clusterProperties.getConnectionTimeout());
+ factory.setReadTimeout(clusterProperties.getReadTimeout());
Review Comment:
read/write/connect
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
