moremind commented on code in PR #5604:
URL: https://github.com/apache/shenyu/pull/5604#discussion_r1717004954
##########
shenyu-admin/src/main/java/org/apache/shenyu/admin/mapper/NamespacePluginRelMapper.java:
##########
@@ -124,22 +123,22 @@ public interface NamespacePluginRelMapper extends
ExistProvider {
* @param namespaceId namespace id.
* @return rows int
*/
- int deleteByIds(List<String> ids, String namespaceId);
+ int deleteByIdsAndNamespaceId(List<String> ids, String namespaceId);
/**
* select all.
Review Comment:
change the comment
##########
shenyu-admin/src/main/java/org/apache/shenyu/admin/mapper/NamespacePluginRelMapper.java:
##########
@@ -65,20 +65,19 @@ public interface NamespacePluginRelMapper extends
ExistProvider {
/**
* select plugin by namespacePluginId.
Review Comment:
change the comment
##########
shenyu-admin/src/main/java/org/apache/shenyu/admin/mapper/SelectorMapper.java:
##########
@@ -44,6 +44,15 @@ public interface SelectorMapper extends ExistProvider {
@Override
Boolean existed(@Param("id") Serializable id);
+ /**
+ * select selector by id.
Review Comment:
change the comment
##########
shenyu-admin/src/main/java/org/apache/shenyu/admin/mapper/NamespacePluginRelMapper.java:
##########
@@ -124,22 +123,22 @@ public interface NamespacePluginRelMapper extends
ExistProvider {
* @param namespaceId namespace id.
* @return rows int
*/
- int deleteByIds(List<String> ids, String namespaceId);
+ int deleteByIdsAndNamespaceId(List<String> ids, String namespaceId);
/**
* select all.
*
* @param namespaceId namespace id.
Review Comment:
same question
##########
shenyu-admin/src/main/java/org/apache/shenyu/admin/mapper/DiscoveryUpstreamMapper.java:
##########
@@ -38,15 +38,15 @@ public interface DiscoveryUpstreamMapper extends
ExistProvider {
Boolean existed(@Param("id") Serializable key);
/**
- * selectByIds.
+ * selectByIdsAndNamespaceId.
Review Comment:
why change comment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
