moremind commented on code in PR #5616:
URL: https://github.com/apache/shenyu/pull/5616#discussion_r1721653337
##########
shenyu-admin/src/main/java/org/apache/shenyu/admin/service/register/AbstractShenyuClientRegisterServiceImpl.java:
##########
@@ -64,7 +66,9 @@
* Abstract strategy.
*/
public abstract class AbstractShenyuClientRegisterServiceImpl extends
FallbackShenyuClientRegisterService implements ShenyuClientRegisterService {
-
+
+ private final Logger logger =
LoggerFactory.getLogger(AbstractShenyuClientRegisterServiceImpl.class);
Review Comment:
use LOG
##########
shenyu-admin/src/main/java/org/apache/shenyu/admin/service/register/ShenyuClientRegisterGrpcServiceImpl.java:
##########
@@ -75,6 +79,7 @@ protected String ruleHandler() {
@Override
protected void registerMetadata(final MetaDataRegisterDTO metaDataDTO) {
MetaDataService metaDataService = getMetaDataService();
+ LOG.info("grpc register metadata:{}",
GsonUtils.getInstance().toJson(metaDataDTO));
Review Comment:
may debug level?
##########
shenyu-admin/src/main/java/org/apache/shenyu/admin/service/register/ShenyuClientRegisterGrpcServiceImpl.java:
##########
@@ -140,6 +145,7 @@ public String offline(final String selectorName, final
List<URIRegisterDTO> offl
removeDiscoveryUpstream(selectorDO.getId(),
grpcUpstream.getUpstreamUrl());
}
DiscoverySyncData discoverySyncData = fetch(selectorDO.getId(),
selectorDO.getName(), pluginName);
+ LOG.info("grpc offline discoverySyncData:{}",
GsonUtils.getInstance().toJson(discoverySyncData));
Review Comment:
may debug level?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
