moremind commented on code in PR #5614: URL: https://github.com/apache/shenyu/pull/5614#discussion_r1730020283
########## shenyu-web/src/main/java/org/apache/shenyu/web/fallback/DefaultFallbackController.java: ########## @@ -1,62 +1,62 @@ -/* - * Licensed to the Apache Software Foundation (ASF) under one or more - * contributor license agreements. See the NOTICE file distributed with - * this work for additional information regarding copyright ownership. - * The ASF licenses this file to You under the Apache License, Version 2.0 - * (the "License"); you may not use this file except in compliance with - * the License. You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, software - * distributed under the License is distributed on an "AS IS" BASIS, - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - * See the License for the specific language governing permissions and - * limitations under the License. - */ - -package org.apache.shenyu.web.fallback; - -import org.apache.shenyu.plugin.api.result.ShenyuResultEnum; -import org.apache.shenyu.plugin.api.result.ShenyuResultWrap; -import org.springframework.web.bind.annotation.GetMapping; -import org.springframework.web.bind.annotation.RequestMapping; -import org.springframework.web.bind.annotation.RestController; - -/** - * The default fallback for hystrix plugin and resilience4j plugin. - */ -@RestController -@RequestMapping("/fallback") -public class DefaultFallbackController { - - /** - * default fallback for hystrix. - * - * @return the shenyu result - */ - @GetMapping("/hystrix") - public Object hystrixPluginFallback() { - return ShenyuResultWrap.error(ShenyuResultEnum.HYSTRIX_PLUGIN_FALLBACK, null); - } - - /** - * default fallback for resilience4j. - * - * @return the shenyu result - */ - @GetMapping("/resilience4j") - public Object resilience4jFallBack() { - return ShenyuResultWrap.error(ShenyuResultEnum.RESILIENCE4J_PLUGIN_FALLBACK, null); - } - - /** - * Sentinel fall back object. - * - * @return the object - */ - @GetMapping("/sentinel") - public Object sentinelFallBack() { - return ShenyuResultWrap.error(ShenyuResultEnum.SENTINEL_PLUGIN_FALLBACK, null); Review Comment: why rewrite this class? ########## shenyu-plugin/shenyu-plugin-security/shenyu-plugin-basic-auth/src/main/java/org/apache/shenyu/plugin/basic/auth/handle/BasicAuthPluginDataHandler.java: ########## @@ -1,72 +1,72 @@ -/* - * Licensed to the Apache Software Foundation (ASF) under one or more - * contributor license agreements. See the NOTICE file distributed with - * this work for additional information regarding copyright ownership. - * The ASF licenses this file to You under the Apache License, Version 2.0 - * (the "License"); you may not use this file except in compliance with - * the License. You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, software - * distributed under the License is distributed on an "AS IS" BASIS, - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - * See the License for the specific language governing permissions and - * limitations under the License. - */ - -package org.apache.shenyu.plugin.basic.auth.handle; - -import java.util.Map; -import java.util.Optional; -import java.util.function.Supplier; - -import org.apache.commons.lang3.StringUtils; -import org.apache.shenyu.common.constant.Constants; -import org.apache.shenyu.common.dto.PluginData; -import org.apache.shenyu.common.dto.RuleData; -import org.apache.shenyu.common.enums.PluginEnum; -import org.apache.shenyu.common.utils.GsonUtils; -import org.apache.shenyu.common.utils.Singleton; -import org.apache.shenyu.plugin.base.cache.CommonHandleCache; -import org.apache.shenyu.plugin.base.handler.PluginDataHandler; -import org.apache.shenyu.plugin.base.utils.BeanHolder; -import org.apache.shenyu.plugin.base.utils.CacheKeyUtils; -import org.apache.shenyu.plugin.basic.auth.config.BasicAuthConfig; -import org.apache.shenyu.plugin.basic.auth.rule.BasicAuthRuleHandle; - Review Comment: why rewrite this class? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@shenyu.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
