misaya295 commented on code in PR #5602: URL: https://github.com/apache/shenyu/pull/5602#discussion_r1743908828
########## shenyu-admin/src/main/java/org/apache/shenyu/admin/model/dto/ScalePolicyDTO.java: ########## @@ -0,0 +1,323 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.shenyu.admin.model.dto; + +import jakarta.validation.constraints.NotNull; +import org.apache.shenyu.admin.mapper.ScalePolicyMapper; +import org.apache.shenyu.admin.validation.annotation.Existed; + +import java.io.Serializable; +import java.util.Objects; + +/** + * this is scale policy from by web front. + */ +public class ScalePolicyDTO implements Serializable { + + private static final long serialVersionUID = 3319087894871820638L; + + + /** + * primary key id. + */ + @Existed(provider = ScalePolicyMapper.class, nullOfIgnore = true, message = "scale policy is not existed") + private String id; + + /** + * sort. + */ + @NotNull + private Integer sort; + + /** + * status 1:enable 0:disable. + */ + @NotNull + private Integer status; + + /** + * number of bootstrap. + */ + private Integer num; + + /** + * begin time. + */ + private String beginTime; Review Comment: use localdatetime ########## shenyu-admin/src/main/java/org/apache/shenyu/admin/model/dto/ScalePolicyDTO.java: ########## @@ -0,0 +1,323 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.shenyu.admin.model.dto; + +import jakarta.validation.constraints.NotNull; +import org.apache.shenyu.admin.mapper.ScalePolicyMapper; +import org.apache.shenyu.admin.validation.annotation.Existed; + +import java.io.Serializable; +import java.util.Objects; + +/** + * this is scale policy from by web front. + */ +public class ScalePolicyDTO implements Serializable { + + private static final long serialVersionUID = 3319087894871820638L; + + + /** + * primary key id. + */ + @Existed(provider = ScalePolicyMapper.class, nullOfIgnore = true, message = "scale policy is not existed") + private String id; + + /** + * sort. + */ + @NotNull + private Integer sort; + + /** + * status 1:enable 0:disable. + */ + @NotNull + private Integer status; + + /** + * number of bootstrap. + */ + private Integer num; + + /** + * begin time. + */ + private String beginTime; + + /** + * end time. + */ + private String endTime; Review Comment: use localdatetime -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@shenyu.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
